Jeff King <p...@peff.net> writes: > I think messages to stderr are generally fair game for changing, even in > plumbing. In many cases they are also translated (and I would argue that > these messages probably should be translated, too).
I think I agree. My first reaction to this thread indeed was "Why isn't this marked for translation?"; as to the change proposed by the patch itself, my reaction actually was "Meh" ;-) > That being said, CodingGuidelines says: > > - Do not end error messages with a full stop. Thanks for pointing it out---I forgot about that one. I do not think there was a concrete reason why they should not end with a full stop, other than "be consistent with existing ones that do not end with a full stop", though. > This isn't an error message exactly, but I think it's in the same vein. > I will note that we have not historically been consistent here, though > (as evidenced by the noted message in git-merge). -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
