Jeff King <p...@peff.net> writes: > The only one I can think of is that if something leaves cruft in > $TMPDIR, it could affect later tests that want to `git add` > indiscriminately.
Or "git ls-files -u", "git clean", etc. I'd mostly worry about a failed test in which a program dies without a chance to clean up after itself, and letting the cruft affecting the next test. > OTOH, I do not think putting things in /tmp is hurting anything. I was > mostly just surprised by it. Moving TMPDIR into somewhere under t/ would force us to do more work to clean things up, and it would probably be a good thing in the longer term. I just checked my /tmp, and I see a lot of directories whose name look like mktemp generated one, with a single socket 's' in them. I wouldn't be surprised if they turn out to be from our tests that expect failure, killing a daemon that does not properly clean after itself. People probably would not notice if they are in /tmp, and if we moved TMPDIR to the trash, we still wouldn't (because running tests successfully without "-d" option will remove the trash directory at the end), but if it were dropped somewhere in the source tree, we have a better chance of noticing it. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
