Am 02.06.2016 um 20:14 schrieb Junio C Hamano:
> Thomas Braun <thomas.br...@virtuell-zuhause.de> writes:
> 
>> +    untracked_state="$(__git_find_on_cmdline "--untracked-files=no\
>> +            --untracked-files=normal --untracked-files=all")"
> 
> Just wondering but does this help my use of the command like
> 
>       $ git status -uno <TAB>
> 
> or do I now have to spell it out like
> 
>       $ git status --untracked-files=no <TAB>
> 
> to take advantage of it?

I was unsure if I should support the short option (-u) as well. On
thinking about it again there is little use of only doing it for the
long option.
Will be handled in a reroll.

>> +    untracked_state=${untracked_state##--untracked-files=}
>> +
>> +    if [ -z "$untracked_state" ]; then
>> +            untracked_state="$(git --git-dir="$(__gitdir)" config 
>> "status.showUntrackedFiles")"
>> +    fi
>> +
>> +    case "$untracked_state" in
>> +            no)
>> +                    # --ignored option does not matter
> 
> Style.  I see existing case/esac statements that use this style, but
> our preference is not to indent case arms like this; rather:
> 
>       case "$untracked_state" in
>         no)
>               # --ignored ...
> 
> which saves the indentation one level overall.

thanks, will be fixed.

>> +                    complete_opt=
>> +                    ;;
>> +            all|normal|*)
>> +                    complete_opt="--cached --directory --no-empty-directory 
>> --others"
>> +
>> +                    if [ -n "$(__git_find_on_cmdline "--ignored")" ]; then
> 
> Same question as the "--untracked-files=no vs -uno" applies here.

Is there a short version of --ignored? I could not find one in the help,
and from a look into cmd_status in commit.c I would say there is none.

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to