Johannes Sixt <j...@kdbg.org> writes: > Also, you should investigate cases where "environment" is at the > beginning of a line, because then the variable name is most likely at > the end of the previous line. At the least, you missed an occurrence > of GIT_EXTERNAL_DIFF in diff-config.txt.
In theory, yes, but the goal of this patch is not to get everything right, only to make one step in the right direction. Doing it with perl substitutions allows making a relatively large step with minor effort. Obviously, other patches getting more consistency elsewhere are welcome, but I don't think they have to be part of this series. On a side note, this patch is written by students of mine as part of a school project which ends this Friday, leaving very little time for them to write more patches. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
