Michael Haggerty <mhag...@alum.mit.edu> writes: > On 06/09/2016 06:14 PM, Junio C Hamano wrote: >> Michael Haggerty <mhag...@alum.mit.edu> writes: >> >>>>> +static struct ref_store *main_ref_store = NULL; >>>>> + >>>>> +static struct ref_store *submodule_ref_stores = NULL; >>>> >>>> Let's let BSS take care of these initialization. >> [...] >> Lack of "= ..." is a clear-enough clue that the code wants these >> pointers initialized to NULL. >> [...] > > OK. While I'm at it I'll add docstrings for these variables.
Yeah, if you explain what they are used for, it would become obvious why their natural initial state is NULL. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
