Hi Peff, On Thu, 7 Jul 2016, Jeff King wrote:
> We have two forms of write_file(): one that dies, and one > that returns an error. However, the latter has only a single > caller, which immediately dies anyway (after producing a > message that is not really any more informative than > write_file's generic die(), and arguably worse because it > does not give the actual filename). This is more an illustration of unnecessarily duplicated code, isn't it? There are *tons* of instances in Git's code where writing to a file is implemented separately (and differently). It would make tons of sense to consolidate all of these instances, methinks. The diffstat should look *very* pleasing. Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
