On Mon, Jul 18, 2016 at 12:43:27PM -0700, Junio C Hamano wrote: > -- >8 -- > test: check "unzip" and "unzip -a" > > Different platforms have implementations "unzip" that behave > differently. Most of the tests we use GIT_UNZIP we only care about > the command to be able to extract from *.zip archive, but one test > in t5003 wants it to also be able to grok the "-a" option. > > Prepare a sample zip file that has a single text file in it, and try > extracting its contents to see GIT_UNZIP is usable. when setting > UNZIP prerequisite. Similarly, set UNZIP_AUTOTEXT prerequisite by > running GIT_UNZIP with the "-a" option.
I like the direction here, modulo the problems with "-a" that Eric pointed out. Maybe "zip -l" would be a better approach. One nit: > +test_lazy_prereq UNZIP_AUTOTEXT ' > + ( > + mkdir unzip-autotext && > + cd unzip-autotext > + "$GIT_UNZIP" -a "$TEST_DIRECTORY"/t5003/infozip-text.zip && > + test -f text > + ) > +' I don't think we need the extra directory or the subshell here. test_lazy_prereq takes care of that for us. > diff --git a/t/t5003/infozip-text.zip b/t/t5003/infozip-text.zip > new file mode 100644 > index 0000000..a019acb > Binary files /dev/null and b/t/t5003/infozip-text.zip differ Couldn't apply this locally without --binary, of course. :) -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
