Hi and thanks for your reply.
On Tue, Jul 26, 2016 at 3:55 PM, Johannes Schindelin
<[email protected]> wrote:
> Hi Orgad
>
> On Tue, 26 Jul 2016, Orgad Shaneh wrote:
>
>> From: Orgad Shaneh <[email protected]>
>
> This is unnecessary, as it matches your email address.
>
>> include also commit-msg hook.
>
> This comment was a bit cryptic, until I read the patch. Now I find that
> comment redundant with the patch.
This brings the short help in line with the documentation. I should
have stated that in the commit message.
>
> However, I think that...
>
>> - OPT_BOOL('n', "no-verify", &no_verify, N_("bypass pre-commit
>> hook")),
>> + OPT_BOOL('n', "no-verify", &no_verify, N_("bypass pre-commit
>> and commit-msg hooks")),
>
>
> ... it may be more desirable to future-proof this simply by saying "bypass
> hooks".
That wouldn't be correct. prepare-commit-msg is not suppressed by this flag.
> In the alternative, it would be good if the commit message could
> convincingly make the case that there are no other hooks that will be
> skipped with -n.
>
> Of course, I could go and look at the source code to convince myself. But
> it is really the duty of the commit message to be already convincing
> enough.
>
> Ciao,
> Dscho
I don't have much experience with submitting patches to Git. How do I
edit the commit message? Submit it as a new patch?
- Orgad
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
