Ingo Brückl <i...@wupperonline.de> writes: > Subject: Re: [PATCH v2 2/3] Make test t3700-add.sh more robust
Please check output from "git shortlog --no-merges -100" to see how your titles play well with others. We typically prefix the title with a specific area, a colon, and a sentence that does not begin in a capital letter and does not end with a full-stop. > Don't rely on chmod to work on the underlying platform (although it > wouldn't harm the result of the '--chmod=-x' test). Directly check the > result of the --chmod option. > > Add a test_mode_in_index helper function in order to check for success. Hmph, I do not immediately see the point of having the helper in test-lib-functions.sh, though. This helper looks more or less specific to this test script. In any case, I think addition of the "test_mode_in_index" helper and conversion from case/esac to the helper should be a separate patch from what this patch wants to do, which is to merge two more-or-less redundant tests into one. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
