On Sat, Jul 30, 2016 at 07:36:23PM +0200, René Scharfe wrote: > Replace uses of strbuf_addf() for adding strings with more lightweight > strbuf_addstr() calls. > > In http-push.c it becomes easier to see what's going on without having > to verfiy that the definition of PROPFIND_ALL_REQUEST doesn't contain > any format specifiers.
Nice. I care a lot less about whether "addf" or "addstr" is more efficient. But the second point, that it makes the intent clearer, is a big win. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
