jbertram commented on a change in pull request #2681: ARTEMIS-2308 Support 
exporting metrics
URL: https://github.com/apache/activemq-artemis/pull/2681#discussion_r287859553
 
 

 ##########
 File path: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/AddressControl.java
 ##########
 @@ -101,19 +103,19 @@
    @Attribute(desc = "names of all bindings (both queues and diverts) bound to 
this address")
    String[] getBindingNames() throws Exception;
 
-   @Attribute(desc = "number of messages added to all the queues for this 
address")
+   @Attribute(desc = "number of messages currently in all queues bound to this 
address (includes scheduled, paged, and in-delivery messages)")
 
 Review comment:
   I didn't refactor the description here because I'm not actually exported 
this metric since it will be easy to aggregate all the message counts of all 
the queues on the address in whatever system the metrics are exported to.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to