tabish121 commented on issue #359: AMQ-7211 STOMP: Do not clear pending ACKs on COMMIT URL: https://github.com/apache/activemq/pull/359#issuecomment-497096242 Clearing the pending acks was intended to mitigate leaks in the ack ID tracking and by removing the clears the original issue is reintroduced. The clear isn't correct as noted here but the accounting of the ack Ids needs to be done such that we aren't leaking them after TX operations or client and client-individual acknowledgements. There is a more serious issue here in that the ack Ids are lost when a Transaction is aborted and so the client cannot again ACK a message or NACK it for that matter as the entries for some or all the TX enlisted messages are lost (depending on ACK mode). I am working on a fix that should mitigate all these issues and adding additional tests to cover this
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
