wy96f commented on a change in pull request #2683: NO-JIRA typo on logger
URL: https://github.com/apache/activemq-artemis/pull/2683#discussion_r289229803
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/replication/ReplicationManager.java
##########
@@ -613,7 +613,7 @@ private void flushReplicationStream(FlushAction action)
throws Exception {
action.reset();
replicationStream.execute(action);
if (!action.await(this.timeout, TimeUnit.MILLISECONDS)) {
Review comment:
The docs says initial-replication-sync-timeout means "the amount of time the
replicating server will wait at the completion of the initial replication
process for the replica to acknowledge it has received all the necessary data.
The default is 30,000 milliseconds. **Note:** during this interval any journal
related operations will be blocked". So it's the time waiting for the last ack
and i assume "timeout" should be used in the middle of replication process?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
