clebertsuconic commented on a change in pull request #2730: ARTEMIS-2399 Fix
performance degradation when there are a lot of subscribers
URL: https://github.com/apache/activemq-artemis/pull/2730#discussion_r296728960
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageCursorProviderImpl.java
##########
@@ -74,6 +75,8 @@
private final SoftValueLongObjectHashMap<PageCache> softCache;
+ private final LongObjectHashMap<PageCache> indexCacheMap;
Review comment:
Wouldn't this break SoftReferences cleanup? meaning a page will be leaving
forever.
I would use a SoftValueLongObjectHashMap here as well. In case memory is
low, we want PageCache to be releasable. And this would make hard references on
pageCache.
<<this is a question>>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
