michaelandrepearce commented on a change in pull request #2727: ARTEMIS-2394
Improve scheduling sync for AMQPConnectionContext
URL: https://github.com/apache/activemq-artemis/pull/2727#discussion_r297873992
##########
File path:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/AMQPConnectionContext.java
##########
@@ -87,9 +89,8 @@
private final boolean useCoreSubscriptionNaming;
- private boolean isSchedulingCancelled;
- private ScheduledFuture scheduledFuture;
- private final Object schedulingLock = new Object();
+ private static final FutureTask<Void> voidFuture = new FutureTask<>(() -> {
}, null);
Review comment:
on that note what is its purpose? surely can just set the reference to null
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
