jbertram commented on issue #2746: ARTEMIS-2412: Allow CF configuration through JNDI references URL: https://github.com/apache/activemq-artemis/pull/2746#issuecomment-509703953 I ran the PR build on my local machine and it passed. This PR looks good, but I hesitate to merge it without any kind of test. Perhaps add a test to `org.apache.activemq.artemis.tests.unit.jms.jndi.ObjectFactoryTest`? This looks like the right area for testing this functionality. Nice work so far!
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
