michaelpearce-gain commented on a change in pull request #2775: ARTEMIS-2435
Configuration on device-block-size through CLI / broker.xml
URL: https://github.com/apache/activemq-artemis/pull/2775#discussion_r309092043
##########
File path:
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/Create.java
##########
@@ -266,10 +266,12 @@
@Option(name = "--no-fsync", description = "Disable usage of fdatasync
(channel.force(false) from java nio) on the journal")
private boolean noJournalSync;
+ @Option(name = "--device-block-size", description = "The block size by the
device, default at 4096.")
Review comment:
should this be journal-device-block-size.
e.g. what occurs in future where want to tune the others, and they maybe
using other disks with other block sizes, might be best to namespace this now,
so in future doesnt cause any issue
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
