michaelandrepearce commented on a change in pull request #2793: ARTEMIS-2452
group-name ignored in shared store colocated setup
URL: https://github.com/apache/activemq-artemis/pull/2793#discussion_r314211592
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/BackupRequestMessage.java
##########
@@ -34,12 +34,14 @@ public BackupRequestMessage() {
}
public BackupRequestMessage(int backupSize,
+ SimpleString nodeID,
String journalDirectory,
String bindingsDirectory,
String largeMessagesDirectory,
String pagingDirectory) {
super(BACKUP_REQUEST);
this.backupSize = backupSize;
+ this.nodeID = nodeID;
Review comment:
Please make a v2 version, this would be a breaking change, for anyone with
existing clusters
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
