[GitHub] [activemq-artemis] wy96f edited a comment on issue #2750: ARTEMIS-2399 Improve performance when there are a lot of subscribers

[GitBox]

wy96f edited a comment on issue #2750: ARTEMIS-2399 Improve performance when 
there are a lot of subscribers
URL: https://github.com/apache/activemq-artemis/pull/2750#issuecomment-521938303
 
 
   @michaelandrepearce squashed commits and pushed. BTW, I added some code to 
avoid file leak in race conditions in PageSubscriptionImpl::internalGetNext() :
   
   `           
              serverMessage = ((PageReader) cache).getMessage(retPos, false, 
true);
               PageCache previousPageCache = 
pageReaders.putIfAbsent(retPos.getPageNr(), (PageReader) cache);
               if (previousPageCache != null && previousPageCache != cache) {
                  // Maybe other cursor iterators have added page reader, we 
have to close this one to avoid file leak
                  cache.close();
               }
   `

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services