michaelandrepearce commented on a change in pull request #2785: ARTEMIS-2442
throw ActiveMQResourceLimitException if session/queue limit is reached
URL: https://github.com/apache/activemq-artemis/pull/2785#discussion_r315049421
##########
File path:
artemis-commons/src/main/java/org/apache/activemq/artemis/api/core/ActiveMQExceptionType.java
##########
@@ -261,6 +261,12 @@ public ActiveMQException createException(String msg) {
public ActiveMQException createException(String msg) {
return new ActiveMQReplicationTimeooutException(msg);
}
+ },
+ RESOURCE_LIMIT_REACHED(221) {
Review comment:
Point here just because theyre catching the base doesnt mean everyone is
By changing the exception should try make it a extended of the current so
people dont get any shock changes in their error handling logic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
