michaelpearce-gain commented on a change in pull request #2791: ARTEMIS-2450
page-size-bytes should not be greater than Integer.MAX_VALUE
URL: https://github.com/apache/activemq-artemis/pull/2791#discussion_r315289774
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java
##########
@@ -597,11 +597,11 @@ public void parseMainConfig(final Element e, final
Configuration config) throws
config.setJournalSyncNonTransactional(getBoolean(e,
"journal-sync-non-transactional", config.isJournalSyncNonTransactional()));
- config.setJournalFileSize(getTextBytesAsIntBytes(e, "journal-file-size",
config.getJournalFileSize(), Validators.GT_ZERO));
+ config.setJournalFileSize(getTextBytesAsIntBytes(e, "journal-file-size",
config.getJournalFileSize(), Validators.POSITIVE_INT));
int journalBufferTimeout = getInteger(e, "journal-buffer-timeout",
config.getJournalType() == JournalType.ASYNCIO ?
ArtemisConstants.DEFAULT_JOURNAL_BUFFER_TIMEOUT_AIO :
ArtemisConstants.DEFAULT_JOURNAL_BUFFER_TIMEOUT_NIO, Validators.GE_ZERO);
- int journalBufferSize = getTextBytesAsIntBytes(e, "journal-buffer-size",
config.getJournalType() == JournalType.ASYNCIO ?
ArtemisConstants.DEFAULT_JOURNAL_BUFFER_SIZE_AIO :
ArtemisConstants.DEFAULT_JOURNAL_BUFFER_SIZE_NIO, Validators.GT_ZERO);
+ int journalBufferSize = getTextBytesAsIntBytes(e, "journal-buffer-size",
config.getJournalType() == JournalType.ASYNCIO ?
ArtemisConstants.DEFAULT_JOURNAL_BUFFER_SIZE_AIO :
ArtemisConstants.DEFAULT_JOURNAL_BUFFER_SIZE_NIO, Validators.POSITIVE_INT);
Review comment:
change was not needed here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
