michaelpearce-gain commented on a change in pull request #2806: ARTEMIS-2459
Fix err in the replacement of a non-destructively consumed LVQ message
URL: https://github.com/apache/activemq-artemis/pull/2806#discussion_r316225950
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/RefsOperation.java
##########
@@ -174,7 +174,7 @@ public void afterCommit(final Transaction tx) {
if (pagedMessagesToPostACK != null) {
for (MessageReference refmsg : pagedMessagesToPostACK) {
((PagedReference)refmsg).removePendingFlag();
- if (((PagedReference) refmsg).isLargeMessage()) {
+ if (((PagedReference) refmsg).isLargeMessage() &&
!queue.isNonDestructive()) {
Review comment:
would you not need to check the ack type? e.g. what if it was expired or
killed (i might be having another douche moment )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
