michaelandrepearce edited a comment on issue #2802: ARTEMIS-2457 implement ring queue URL: https://github.com/apache/activemq-artemis/pull/2802#issuecomment-524213706 Is there added ability to update the size? I really would like this sorted before merge as it stands with it not being implemented inside the main queueimpl i beleive it makes it very hard to implement. Thus my original feedback / query to why have it as independent type, instead of implementing within queueimpl. Also doing it there makes it possible to deactivate also. As then one would simply update size to -1 As such im a little -1 having brand new queue type. This really should just be a queue level setting. If the need or want to keep logic clean this can still be done by making new abstractions within queueimpl. E.g. like priority consumers or message group extensions.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
