clebertsuconic commented on a change in pull request #2799: ARTEMIS-2453 Fixing 
deadLock between destroyQueue and removeAddressInfo
URL: https://github.com/apache/activemq-artemis/pull/2799#discussion_r317727681
 
 

 ##########
 File path: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java
 ##########
 @@ -484,7 +482,7 @@ public QueueBinding updateQueue(SimpleString name,
                                    Long delayBeforeDispatch,
                                    SimpleString user,
                                    Boolean configurationManaged) throws 
Exception {
-      synchronized (addressLock) {
+      synchronized (this) {
 
 Review comment:
   just realized your comment here. We could have done that.. 
   This would be simpler on the diff though. No difference here.
   
   with a simple diff it would been easier to identify what was changed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to