Havret commented on a change in pull request #20: AMQNET-602: Set batchable
flag to false for amqp transfer
URL: https://github.com/apache/activemq-nms-amqp/pull/20#discussion_r318761260
##########
File path: src/NMS.AMQP/Provider/Amqp/AmqpHandler.cs
##########
@@ -0,0 +1,44 @@
+using Amqp.Framing;
+using Amqp.Handler;
+
+namespace Apache.NMS.AMQP.Provider.Amqp
+{
+ internal class AmqpHandler : IHandler
+ {
+ private readonly AmqpConnection connection;
+
+ public AmqpHandler(AmqpConnection connection)
+ {
+ this.connection = connection;
+ }
+
+ public bool CanHandle(EventId id)
+ {
+ switch (id)
+ {
+ case EventId.SendDelivery:
+ case EventId.ConnectionRemoteOpen:
+ case EventId.ConnectionLocalOpen:
+ return true;
+ default:
+ return false;
+ }
+ }
+
+ public void Handle(Event protocolEvent)
+ {
+ switch (protocolEvent.Id)
+ {
+ case EventId.SendDelivery when protocolEvent.Context is
IDelivery delivery:
+ delivery.Batchable = false;
Review comment:
Are you sure this is that simple?
I see 3 options to address this issue:
1. Do what you suggested above.
2. Change hard-coded settled mode for sender link to Mixed.
3. Implement presettle policy in the same way as it is implemented in qpid
jms.
But either way I would address this in a separate PR. I've create an issue
https://issues.apache.org/jira/browse/AMQNET-608 and I've sent email to with
proposed solutions to active mq mailing list to pick up community's brains
regarding to this one.
@michaelandrepearce What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
