cjwmorgan-sol commented on issue #29: AMQNET-610: Race conditions during consumer creation URL: https://github.com/apache/activemq-nms-amqp/pull/29#issuecomment-530044362 Seem pretty good to me however I did find one exception when trying to shutdown a connection with live traffic: PubSubLogger 9/10/2019 12:44:06 PM Error: Exception occurred: Apache.NMS.IllegalStateException: The Session is closed at Apache.NMS.AMQP.NmsSession.CheckClosed() at Apache.NMS.AMQP.NmsSession.get_AcknowledgementMode() at Apache.NMS.AMQP.NmsMessageConsumer.SetAcknowledgeCallback(InboundMessageDispatch envelope) at Apache.NMS.AMQP.NmsMessageConsumer.OnInboundMessage(InboundMessageDispatch envelope) at Apache.NMS.AMQP.NmsSession.OnInboundMessage(InboundMessageDispatch envelope) at Apache.NMS.AMQP.NmsConnection.OnInboundMessage(InboundMessageDispatch envelope) at Apache.NMS.AMQP.Provider.Failover.FailoverProvider.OnInboundMessage(InboundMessageDispatch envelope) at Apache.NMS.AMQP.Provider.Amqp.AmqpConsumer.OnMessage(IReceiverLink receiver, Message amqpMessage) at Amqp.ReceiverLink.OnTransfer(Delivery delivery, Transfer transfer, ByteBuffer buffer) at Amqp.Session.OnTransfer(Transfer transfer, ByteBuffer buffer) at Amqp.Connection.OnFrame(ByteBuffer buffer) I believe this can be fixed by using the Session.SessionInfo.AcknowledgementMode instead of Session.AcknowledgementMode in the Apache.NMS.AMQP.NmsMessageConsumer.SetAcknowledgeCallback method. I tried this and it worked. However, this seems somewhat odd to though as my application called stop on the connection before closing the connection.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
