clebertsuconic commented on a change in pull request #2833: ARTEMIS-2483 Sync
calculation should use the block size
URL: https://github.com/apache/activemq-artemis/pull/2833#discussion_r322942100
##########
File path:
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/util/SyncCalculation.java
##########
@@ -77,7 +77,10 @@ public static long syncTest(File datafolder,
int maxAIO,
JournalType journalType) throws Exception {
SequentialFileFactory factory = newFactory(datafolder, fsync,
journalType, blockSize * blocks, maxAIO);
- final boolean asyncWrites = journalType == JournalType.ASYNCIO &&
!syncWrites;
+
+ if (factory instanceof AIOSequentialFileFactory) {
+ factory.setAlignment(blockSize);
Review comment:
Before anyone asks, I have no easy way to create a testcase for this. This
is CLI, and hence this is like an UI tool.
besides these defaults are dependent on platform, so I am on purpose not
writing a testcase for this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
