michaelandrepearce commented on a change in pull request #31: AMQNET-612:
ObjectMessage shouldn't have jms-msg-type set
URL: https://github.com/apache/activemq-nms-amqp/pull/31#discussion_r323929755
##########
File path: src/NMS.AMQP/Provider/Amqp/Message/AmqpCodec.cs
##########
@@ -55,16 +55,26 @@ private static AmqpNmsMessageFacade
CreateFromMsgAnnotation(MessageAnnotations m
{
case MessageSupport.JMS_TYPE_MSG:
return new AmqpNmsMessageFacade();
- case MessageSupport.JMS_TYPE_BYTE:
Review comment:
i would keep byte here, keep the case handling in the order of they are in
JMS and the ordinals.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
