cjwmorgan-sol commented on issue #28: NO-JIRA: Extend logging URL: https://github.com/apache/activemq-nms-amqp/pull/28#issuecomment-531410287 I took a look at the qpid jms implementation and it catches Runtime Exceptions not all Exception. The dotnet equivalent would be SystemException. This would allow custom Exceptions to be handled by the connection ExceptionListener just like qpid jms does. Also until the nms provider catches up to qpid jms in terms of their TracableMessage approach application error should not hidden by the provider. Like in the current implementation. Warning logs for application errors seems to be the best middle ground as this follows the Java logging level with qpid jms would have used. Given that there is no other indication for the application failure. @michaelandrepearce since nms does not have a "Trace" level are you suggesting the log level be Debug? Application errors being does not sound right to me.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
