franz1981 commented on a change in pull request #2845: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file (AGAIN) URL: https://github.com/apache/activemq-artemis/pull/2845#discussion_r327950181
########## File path: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnection.java ########## @@ -355,12 +373,24 @@ private boolean canWrite(final int requiredCapacity) { return canWrite; } - private Object getFileObject(RandomAccessFile raf, FileChannel fileChannel, long offset, int dataSize) { - if (channel.pipeline().get(SslHandler.class) == null) { - return new NonClosingDefaultFileRegion(fileChannel, offset, dataSize); + private Object getFileObject(FileChannel fileChannel, long offset, int dataSize) { + if (USE_FILE_REGION && channel.pipeline().get(SslHandler.class) == null) { Review comment: I see, but I've tried to raise the highwatermark value, the outbound TCP buffer and lower the size of chunks to be 32 K getting the same error... I will try to override the back-pressure mechanism we use on NettyConnection making it to return just true... If we will found an error on Netty side I will send a pr there instead ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services