brusdev commented on a change in pull request #2850: ARTEMIS-2504 implement
retroactive addresses
URL: https://github.com/apache/activemq-artemis/pull/2850#discussion_r328041981
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
##########
@@ -1971,7 +1988,9 @@ private synchronized int iterQueue(final int flushLimit,
if (filter1 == null || filter1.match(ref.getMessage())) {
messageAction.actMessage(tx, ref);
- iter.remove();
+ if (remove) {
Review comment:
Do we need the same check for scheduledDelivery messages
(https://github.com/apache/activemq-artemis/blob/master/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ScheduledDeliveryHandlerImpl.java#L128)
and paged messages
(https://github.com/apache/activemq-artemis/blob/master/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java#L2002)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
