michaelandrepearce commented on a change in pull request #2850: ARTEMIS-2504 
implement retroactive addresses
URL: https://github.com/apache/activemq-artemis/pull/2850#discussion_r328401160
 
 

 ##########
 File path: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java
 ##########
 @@ -1170,6 +1172,10 @@ public SecuritySettingPlugin run() {
             
addressSettings.setDefaultConsumerWindowSize(XMLUtil.parseInt(child));
          } else if (DEFAULT_RING_SIZE.equalsIgnoreCase(name)) {
             addressSettings.setDefaultRingSize(XMLUtil.parseLong(child));
+         } else if (RETROACTIVE_MESSAGE_COUNT.equalsIgnoreCase(name)) {
+            long retroactiveMessageCount = XMLUtil.parseLong(child);
+            Validators.GE_ZERO.validate(DEFAULT_ADDRESS_ROUTING_TYPE, 
retroactiveMessageCount);
 
 Review comment:
   Default address routing type in the validator for msg count?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to