franz1981 edited a comment on issue #2950: ARTEMIS-2604 Save Message decoding when unnecessary URL: https://github.com/apache/activemq-artemis/pull/2950#issuecomment-577046495 @clebertsuconic Sadly seems that while exchanging messages, we trigger the full decode anyway, due to other properties accessed eg `CoreMessage:.getRoutingType`  But, good news about the change already done: that's from *ARTEMIS 2.11*  And the same heap configuration ie `-XX:+UseG1GC -Xms4G -Xmx4G -XX:+AlwaysPreTouch` for *this PR*:  The difference in max pause time is just too much (*7 sec vs 150 ms* to compare them :) There are other metrics, but the point is that we won't produce tons of garbage to decode messages if the `ScheduledDeliveryTime` property isn't set and should cover the most of the cases. The previous results are obtained by loading a journal created by running 30 pairs of Core JMS producers/consumers sending persistent byte messages of 10 bytes size until the broker start to page, with slow consumers (ie performing `Thread::sleep(200)` while consuming messages): this has filled the message journal with a mix of unacked/acked small messages that would stress the heap/GC part of the loading activity instead of the disk. Indeed the whole `data` folder is just `2.5 GB`. I would try with different sizes too, to put under stress the new search property method, that is being benchmarked separately to make it as fast as possible. I strongly encourage any user that make heavy use of the journal and has stress tests while loading journal to try this (@michaelandrepearce @wy96f ?) being aware that ATM it just improve this for Core protocol, but with some help, will get the same for AMQP as well.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
