lrushl commented on issue #9: [AMQNET-565] - .net standard conversion, project reorganization URL: https://github.com/apache/activemq-nms-openwire/pull/9#issuecomment-615897504 Let me share my update on this pr. - 27 unit test are ignored (26 tests are DTC tests that currently not supported on .net core) + 1 tests that most likely was never passing (TestSetEmptyPropertyName)). Furthermore, `TestSetEmptyPropertyName` test fails on all target frameworks.  - 3 unit tests fail on all frameworks all the time.  It looks like the `TestTmpQueueWorksUnderLoad` test was never passing. This test fails on the following [line](https://github.com/apache/activemq-nms-openwire/blob/0ccbe7e8c68d41709375fe6bcbff75dbc8e917fd/test/TempDestinationTest.cs#L197) in test and the following [line in lib](https://github.com/apache/activemq-nms-openwire/blob/0ccbe7e8c68d41709375fe6bcbff75dbc8e917fd/src/Commands/MessageId.cs#L175). The reason for failure is that `MessageId.BrokerSequenceId` of the original message is not updated after a message is produced but the corresponding message on the consumer side does have the `MessageId.BrokerSequenceId` property value set. As far as I understand this value was never supposed to be updated on the producer side. - Regarding the `Thread.Abort` issue mentioned above, I assume that in current implementation we can just enclose it with the `#if` preprocessor directive in order to avoid the `PlatformNotSupportedException` exception. Please share your thoughts on this issue. - The other thing that is not related to this particular PR but none the less worth to be mentioned is that OpenWire protocol on the server has been already updated to version 12. The java client counterpart is also updated to version 12. The other interesting thing is that .net client has some autogenerated pieces of code that are being autogenerated by the [activemq-nms-openwire-generator](https://github.com/apache/activemq-nms-openwire-generator). I'd like to suggest to move issues with unit tests and protocol upgrade (except Thread.Abort) out of the scope of this PR and create separate JIRA tickets for them. Looking forward to your feedback.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
