AntonRoskvist opened a new pull request, #4687: URL: https://github.com/apache/activemq-artemis/pull/4687
I made this revision because I encountered an issue with the previous fix. It's a bit tricky to write a test for, since it is actually already fixed in the most recent broker version for other reasons but I felt there might be some other scenario out there that can still get affected by the current implementation of "ARTEMIS-4185". In short, broker versions after "ARTEMIS-4185" and before "ARTEMIS-4382" would not be able to export and then import compressed messages without them breaking. It's because the COMPRESSED-header is set to false by the producer without a consumer having decompressed the message first. This revision sets the COMPRESSED-header to true at the producer (where compression happens) and to false at the consumer (where decompression happens). I feel this makes more sense regardless of the issue I observed is otherwise fixed or not. I also changed the test to mimic the necessary conditions to trigger the issue I saw with previous broker versions, as well as the previous, more general issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
