clebertsuconic commented on code in PR #4686:
URL: https://github.com/apache/activemq-artemis/pull/4686#discussion_r1406312534


##########
artemis-unit-test-support/src/main/java/org/apache/activemq/artemis/utils/ThreadLeakCheckRule.java:
##########
@@ -295,6 +295,8 @@ private boolean isExpectedThread(Thread thread) {
          return true;
       } else if (threadName.contains("GC Daemon")) {
          return true;
+      } else if 
(threadName.contains("org.eclipse.jetty.util.RolloverFileOutputStream")) {

Review Comment:
   Isn't this hiding a thread leakage? can't we just close the thread instead?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to