MrEasy commented on PR #4699:
URL: 
https://github.com/apache/activemq-artemis/pull/4699#issuecomment-1836160916

   Hi,
   
   > When you hit another feature not working because the thread pool is 
saturated, are you going to add another pool to that feature also?
   If you reach the configured limit, I think everyone is clear that you will 
get delays until resources are freed. Our goal here was to address the issue 
that was more unexpected to us, which lead to the big 10 seconds delays based 
on the flow-control explicitly.
   You could argue, that if going into slow-consumer-handling is not aiming for 
highest throughput anyhow, but having consumer-window-size>0 this has another 
disadvantage for us (see lengthy explanatin by Sascha in slack).
   So goal for us here was to stick to the slow-consumer-handling, but avoiding 
the big 10 seconds influence of the full pool on it.
   
   > Having a warn that the pool is saturated and suggestion to increase would 
probably be a better feature IMO.
   I think that would also be an excellent improvement, since now it is not 
easily visible when the client thread-pool reaches its limit.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to