cshannon commented on PR #4: URL: https://github.com/apache/activemq-openwire/pull/4#issuecomment-1843739420
So I am going to mark this as a draft for now as it works but I think I will update this to be smarter. Right now it just looks for unique sequences which is a good start but I think we should be smarter and just iterate over it after we have sorted the list and also verify that there are no gaps. We wouldn't want sequence ids of something like 1,2,4 we would only want to allow 1,2,3 so I can fix that tomorrow and push a new commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
