gemmellr commented on code in PR #4706:
URL: https://github.com/apache/activemq-artemis/pull/4706#discussion_r1417743646
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java:
##########
@@ -472,6 +474,8 @@ public ActiveMQServerImpl(Configuration configuration,
ConfigurationUtils.validateConfiguration(configuration);
}
+ Security.addProvider(new PemKeyStoreProvider());
Review Comment:
Ick. Should this be static like the call itself, or otherwise gated, to
avoid doing it repeatedly given it can only succeed once? Checking the return
to see whether it wasnt installed if it already was and maybe [trace] log it
didnt add?
Also, this functionality is essentially broker-only unless you happen to
coincidentally be in the same JVM after it starts? The test or docs (which
apply to the client too) dont make that clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
