gemmellr commented on code in PR #4814:
URL: https://github.com/apache/activemq-artemis/pull/4814#discussion_r1482975720
##########
artemis-server/src/test/java/org/apache/activemq/artemis/core/server/cluster/impl/ClusterConnectionImplMockTest.java:
##########
@@ -85,6 +93,53 @@ public void testRemvalOfLocalParameters() throws Exception {
}
+ @Test
+ public void testNullPrimaryOnNodeUp() throws Exception {
+ TransportConfiguration tc = new TransportConfiguration();
+ tc.setFactoryClassName("mock");
+ tc.getParams().put(TransportConstants.LOCAL_ADDRESS_PROP_NAME,
"localAddress");
+ tc.getParams().put(TransportConstants.LOCAL_PORT_PROP_NAME, "localPort");
+
+ ArtemisExecutor executor =
ArtemisExecutor.delegate(Executors.newSingleThreadExecutor(ActiveMQThreadFactory.defaultThreadFactory(getClass().getName())));
+
+ ClusterConnectionImpl cci = new ClusterConnectionImpl(
+ null, //final ClusterManager manager,
+ new TransportConfiguration[]{tc}, //final TransportConfiguration[]
staticTranspConfigs,
+ null, //final TransportConfiguration connector,
+ null, //final SimpleString name,
+ null, //final SimpleString address,
+ 0, //final int minLargeMessageSize,
+ 0L, //final long clientFailureCheckPeriod,
+ 0L, //final long connectionTTL,
+ 0L, //final long retryInterval,
+ 0, //final double retryIntervalMultiplier,
+ 0L, //final long maxRetryInterval,
+ 0, //final int initialConnectAttempts,
+ 0, //final int reconnectAttempts,
+ 0L, //final long callTimeout,
+ 0L, //final long callFailoverTimeout,
+ false, //final boolean useDuplicateDetection,
+ null, //final MessageLoadBalancingType messageLoadBalancingType,
+ 0, //final int confirmationWindowSize,
+ 0, //final int producerWindowSize,
+ () -> executor,//final ExecutorFactory executorFactory,
+ new MockServer(), //final ActiveMQServer server,
+ null, //final PostOffice postOffice,
+ null, //final ManagementService managementService,
+ null, //final ScheduledExecutorService scheduledExecutor,
+ 0, //final int maxHops,
+ new
FakeNodeManager(UUIDGenerator.getInstance().generateStringUUID()), //final
NodeManager nodeManager,
+ null, //final String clusterUser,
+ null, //final String clusterPassword,
+ true, //final boolean allowDirectConnectionsOnly,
+ 0, //final long clusterNotificationInterval,
+ 0 //final int clusterNotificationAttempts)
Review Comment:
Does the commented out parameter code really add enough to warrant keeping
the cruft? It will just go stale as people rework the impl. Even assigning all
the actual variables would probably look nicer (if more verbose..though many
could probably be multi-assigned to reduce line count). The values are mostly
essentially 0/null/false except a small subset. Maybe just comment ones that
are particularly noteworthy?
##########
artemis-server/src/test/java/org/apache/activemq/artemis/core/server/cluster/impl/ClusterConnectionImplMockTest.java:
##########
@@ -85,6 +93,53 @@ public void testRemvalOfLocalParameters() throws Exception {
}
+ @Test
+ public void testNullPrimaryOnNodeUp() throws Exception {
+ TransportConfiguration tc = new TransportConfiguration();
+ tc.setFactoryClassName("mock");
+ tc.getParams().put(TransportConstants.LOCAL_ADDRESS_PROP_NAME,
"localAddress");
+ tc.getParams().put(TransportConstants.LOCAL_PORT_PROP_NAME, "localPort");
+
+ ArtemisExecutor executor =
ArtemisExecutor.delegate(Executors.newSingleThreadExecutor(ActiveMQThreadFactory.defaultThreadFactory(getClass().getName())));
Review Comment:
What shuts this down?
##########
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireProtocolManager.java:
##########
@@ -232,6 +232,13 @@ public OpenWireProtocolManager
setOpenwireUseDuplicateDetectionOnFailover(boolea
@Override
public void nodeUP(TopologyMember member, boolean last) {
+ if (member.getPrimary() == null) {
+ if (logger.isTraceEnabled()) {
+ logger.trace("{} ignoring call with nodeID={}, topologyMember={},
last={}", this, member.getNodeId(), member, last);
Review Comment:
Maybe say what call is being ignored, and why?
##########
artemis-protocols/artemis-openwire-protocol/src/test/java/org/apache/activemq/artemis/core/protocol/openwire/amq/OpenWireProtocolManagerTest.java:
##########
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.core.protocol.openwire.amq;
+
+import java.util.concurrent.Executor;
+import java.util.concurrent.Executors;
+
+import io.netty.buffer.Unpooled;
+import org.apache.activemq.artemis.api.core.client.TopologyMember;
+import org.apache.activemq.artemis.core.buffers.impl.ChannelBufferWrapper;
+import org.apache.activemq.artemis.core.client.impl.TopologyMemberImpl;
+import org.apache.activemq.artemis.core.persistence.StorageManager;
+import
org.apache.activemq.artemis.core.persistence.impl.nullpm.NullStorageManager;
+import org.apache.activemq.artemis.core.protocol.openwire.OpenWireConnection;
+import
org.apache.activemq.artemis.core.protocol.openwire.OpenWireProtocolManager;
+import org.apache.activemq.artemis.core.security.SecurityStore;
+import org.apache.activemq.artemis.core.server.ActiveMQServer;
+import org.apache.activemq.artemis.core.server.ServerSession;
+import org.apache.activemq.artemis.core.server.cluster.ClusterManager;
+import org.apache.activemq.artemis.spi.core.remoting.Connection;
+import org.apache.activemq.artemis.utils.RandomUtil;
+import org.apache.activemq.artemis.utils.actors.OrderedExecutorFactory;
+import org.apache.activemq.command.ConnectionId;
+import org.apache.activemq.command.ConnectionInfo;
+import org.junit.Test;
+import org.mockito.Mockito;
+
+public class OpenWireProtocolManagerTest {
+
+ @Test
+ public void testNullPrimaryOnNodeUp() throws Exception {
+
+ OrderedExecutorFactory orderedExecutorFactory = new
OrderedExecutorFactory(Executors.newFixedThreadPool(5));
Review Comment:
What shuts this down?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
