tabish121 commented on code in PR #4840:
URL: https://github.com/apache/activemq-artemis/pull/4840#discussion_r1511925400


##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/AMQPBrokerConnection.java:
##########
@@ -847,6 +847,7 @@ public MessageWriter 
selectOutgoingMessageWriter(ProtonServerSenderContext sende
             if (message.isLargeMessage()) {
                selected = largeMessageWriter != null ? largeMessageWriter :
                   (largeMessageWriter = new AMQPLargeMessageWriter(sender));
+               largeMessageWriter.openContext(reference);

Review Comment:
   So are you saying a handler can now accept an additional message while it's 
trying to process the previously passed large message ?  That seem rife with 
errors. Otherwise I don't follow what you are saying.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to