gemmellr commented on code in PR #4833: URL: https://github.com/apache/activemq-artemis/pull/4833#discussion_r1512508594
########## artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireMessageConverter.java: ########## @@ -590,9 +590,9 @@ private static ActiveMQMessage toAMQMessage(MessageReference reference, } amqMsg.setCommandId(commandId); - final SimpleString corrId = getObjectProperty(coreMessage, SimpleString.class, OpenWireConstants.JMS_CORRELATION_ID_PROPERTY); - if (corrId != null) { - amqMsg.setCorrelationId(corrId.toString()); + final Object correlationID = coreMessage.getCorrelationID(); + if (correlationID != null) { + amqMsg.setCorrelationId(correlationID.toString()); Review Comment: I think the actual-expected-behaviour should be tested. This specific behaviour wasnt noticed as there is a simply a 'disabled test as it wont send matching bytes', which is not covering what actually was/is expected to happen in this situation either before or after the changes here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org