clebertsuconic commented on code in PR #4840:
URL: https://github.com/apache/activemq-artemis/pull/4840#discussion_r1514721775
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/AMQPLargeMessageReader.java:
##########
@@ -34,7 +34,7 @@ public class AMQPLargeMessageReader implements MessageReader {
private final ProtonAbstractReceiver serverReceiver;
- private AMQPLargeMessage currentMessage;
+ private volatile AMQPLargeMessage currentMessage;
Review Comment:
@tabish121 , @gemmellr currentMessage is set to null as part of the Session
Executor.
We shouldn't have multiple threads messing with the variable at the same
time as we set readable to false and transfer the execution, but I think it
would be safer to set it as volatile.
Let me know if you have a concern here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
