AntonRoskvist commented on code in PR #4836:
URL: https://github.com/apache/activemq-artemis/pull/4836#discussion_r1515958109
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java:
##########
@@ -3919,7 +3919,10 @@ private void createResources(boolean isAutoCreate,
SimpleString destinationAddre
SimpleString destinationQueueName =
prefix.concat(getAddress()).concat(suffix);
SimpleString filter = new SimpleString(String.format("%s = '%s'",
Message.HDR_ORIGINAL_ADDRESS, getAddress()));
try {
- server.createQueue(new
QueueConfiguration(destinationQueueName).setAddress(destinationAddress).setFilterString(filter).setAutoCreated(true).setAutoCreateAddress(true),
true);
+ Queue destinationQueue = server.createQueue(new
QueueConfiguration(destinationQueueName).setAddress(destinationAddress).setFilterString(filter).setAutoCreated(true).setAutoCreateAddress(true),
true);
+ if (destinationQueue != null && destinationQueue.isSwept()) {
+ destinationQueue.setSwept(false);
Review Comment:
Should be done now, hope it looks good... only thing I'm considering is if
the `setSwept` should be done before the `ignoreIfExists`-check instead of
after? Decided against it for now but I can change again if that makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
