jbertram commented on code in PR #4852:
URL: https://github.com/apache/activemq-artemis/pull/4852#discussion_r1523955679
##########
artemis-selector/src/main/java/org/apache/activemq/artemis/selector/filter/JAXPXPathEvaluator.java:
##########
@@ -56,8 +60,11 @@ protected boolean evaluate(String text) {
protected boolean evaluate(InputSource inputSource) {
try {
- return ((Boolean)xpath.evaluate(xpathExpression,
builder.parse(inputSource), XPathConstants.BOOLEAN)).booleanValue();
+ synchronized (builder) {
Review Comment:
I'm not exactly sure if there _should_ be multiple instances. The `builder`
is created in a `static` block in
`org.apache.activemq.artemis.selector.filter.XPathExpression`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
