gemmellr commented on PR #4902: URL: https://github.com/apache/activemq-artemis/pull/4902#issuecomment-2076984557
> I started doing equivalent updates and though the assertNull changes definitely make sense, its not clear a lot of the assertTrue/assertFalse changes necessarily do. They are mostly checking Boolean (rather than boolean) return values, so by changing them to assertTrue/assertFalse they are potentially just going to throw an NPE before the assertion actually happens. I'd be inclined to leave those ones as-is. I went through them all, less were Boolean than it initially seemed. I converted almost all of them (left the 10 or so where the type wasnt even known to be Boolean, since the assertEquals handles both the null and the type) and added assertNotNulls beforehand for the Boolean ones. In addition to these original changes, also converted an assertNotEquals(null, foo) into assertNotNull(foo). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
