clebertsuconic commented on code in PR #4918:
URL: https://github.com/apache/activemq-artemis/pull/4918#discussion_r1588760902
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/ProtonProtocolManagerFactory.java:
##########
@@ -87,7 +87,8 @@ public String getModuleName() {
@Override
public void loadProtocolServices(ActiveMQServer server,
List<ActiveMQComponent> services) {
try {
- AckManager ackManager = AckManagerProvider.getManager(server, false);
+ AckManager ackManager = AckManagerProvider.getManager(server);
+ services.add(ackManager);
Review Comment:
I didn't think so.
If you confirm it to be an issue it wouldn't be critical but it should be
fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
