gemmellr commented on code in PR #4909:
URL: https://github.com/apache/activemq-artemis/pull/4909#discussion_r1602019436
##########
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTConnectionManager.java:
##########
@@ -176,33 +174,27 @@ ServerSessionImpl createServerSession(String username,
String password, String v
return (ServerSessionImpl) serverSession;
}
- void disconnect(boolean failure) {
+ synchronized void disconnect(boolean failure) {
if (session == null || session.getStopped()) {
return;
}
- synchronized (session.getState()) {
Review Comment:
This seems fine in terms of protecting the connect+disconnect calls similar
to before...but, are there other areas synchronising on and accessing or
manipulating the session state that might no longer be protected as before that
still need to be?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
