clebertsuconic commented on code in PR #4975:
URL: https://github.com/apache/activemq-artemis/pull/4975#discussion_r1638322834
##########
artemis-docker/docker-run.sh:
##########
@@ -33,7 +33,11 @@ fi
if ! [ -f ./etc/broker.xml ]; then
CREATE_ARGUMENTS="--user ${ARTEMIS_USER} --password ${ARTEMIS_PASSWORD}
--silent ${LOGIN_OPTION} ${EXTRA_ARGS}"
- echo CREATE_ARGUMENTS=${CREATE_ARGUMENTS}
+ if [[ ${SUPPRESS_CREDENTIALS,,} == "true" ]]; then
+ echo CREATE_ARGUMENTS="--user XXXXX --password XXXXX --silent
${LOGIN_OPTION} ${EXTRA_ARGS}"
Review Comment:
wouldn't be simpler to just not echo CREATE_ARGUMENTS?
just open a JIRA, and remove this line... no need to print that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
