gemmellr commented on code in PR #4989:
URL: https://github.com/apache/activemq-artemis/pull/4989#discussion_r1647531286
##########
pom.xml:
##########
@@ -861,9 +858,7 @@
<configuration>
<forkCount>1</forkCount>
<reuseForks>true</reuseForks>
- <testFailureIgnore>${testFailureIgnore}</testFailureIgnore>
<runOrder>alphabetical</runOrder>
-
<redirectTestOutputToFile>${maven.test.redirectTestOutputToFile}</redirectTestOutputToFile>
Review Comment:
Not strictly related, but since both are using the standard surefire
properties it is superfluous, so when removing the other configuration element
I took this out too.
##########
pom.xml:
##########
@@ -861,9 +858,7 @@
<configuration>
<forkCount>1</forkCount>
<reuseForks>true</reuseForks>
- <testFailureIgnore>${testFailureIgnore}</testFailureIgnore>
<runOrder>alphabetical</runOrder>
-
<redirectTestOutputToFile>${maven.test.redirectTestOutputToFile}</redirectTestOutputToFile>
Review Comment:
Not strictly related other than being the same type of cleanup; since both
are using the standard surefire properties they are superfluous, so when
removing the other configuration element I took this out too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
